replace innerHTML += with proper appendChild

2026-06-05 07:43:43 +03:00
parent 6fab93ebeb
commit d01bbaca54
2 changed files with 7 additions and 3 deletions
--- a/data/static/js/bits/badge-editor.js
+++ b/data/static/js/bits/badge-editor.js
@@ -91,8 +91,10 @@ export function badgeEditorToggleFilePicker(ev, sender, el) {

 export function badgeEditorAddBadge(ev, sender, el) {
  // TODO: page templates do not get updated on mutation
-  const badge = document.getElementById('badge-template').innerText;
-  el.innerHTML += badge;
+  const badgeTemplate = document.getElementById('badge-template').innerText;
+  const parser = new DOMParser();
+  const e = parser.parseFromString(badgeTemplate, 'text/html').body.firstElementChild;
+  el.appendChild(e);
  b.trigger('badgeEditorAssignImgId');
  badgesCount++;
  b.trigger('setBadgeCount');