walk the tree at request time #8

New Issue

2022-07-02T10:31:34Z

xananax commented

2022-07-02 10:31:34 +00:00

Currently, the server reads all files in a given directory prior to opening the port, in _start_server. It then creates a bound endpoint for each file there. This is good for performance, if this was a production server, but in case of file changes (file added, removed, renamed), changes will not be reflected, and it will lead to unexpected behavior for users.

Potential mitigations, in my preferred order:

have the server accept a single method; allow the implementation to remain entirely in userland. then, in userland, do point 2 below.
have the server accept a string match instead of a string for endpoints. If a string contains ? or *, match it instead of using has(). Potentially also accept regexes (or only regexes?). That means the lookup becomes O(n) instead of O(1) of course.
watch the directory for changes, refresh file list on change. Caveats: don't know how easy that is in Godot. Watching files in a cross platform way is usually tricky

Currently, the server reads all files in a given directory prior to opening the port, in `_start_server`. It then creates a bound endpoint for each file there. This is good for performance, if this was a production server, but in case of file changes (file added, removed, renamed), changes will not be reflected, and it will lead to unexpected behavior for users. Potential mitigations, in my preferred order: 1. have the server accept a single method; allow the implementation to remain entirely in userland. then, in userland, do point 2 below. 2. have the server accept a string match instead of a string for endpoints. If a string contains `?` or `*`, match it instead of using `has()`. Potentially also accept regexes (or only regexes?). That means the lookup becomes O(n) instead of O(1) of course. 3. watch the directory for changes, refresh file list on change. Caveats: don't know how easy that is in Godot. Watching files in a cross platform way is usually tricky

xananax added the enhancement label 2022-07-02 10:31:34 +00:00

yagich referenced this issue

2022-07-03 20:46:44 +00:00

make the endpoints at request time #9

yagich commented

2022-07-04 20:04:26 +00:00

closed by #9

yagich closed this issue

2022-07-04 20:04:26 +00:00

Sign in to join this conversation.