yagich/tickle-godot-frontend
1
0
Fork 1
Code Issues 9 Pull Requests 1 Projects Releases Wiki Activity

make the endpoints at request time #9

Merged
yagich merged 2 commits from serve-on-request into main 2022-07-04 20:04:07 +00:00
Conversation 0 Commits 2 Files Changed 2 +19 -46
yagich commented 2022-07-03 20:46:44 +00:00
Owner
Copy Link

partially addresses #8.
the old server flow was:

  1. request server start
  2. make an endpoint for every file in the server directory, with a bind being the file name
  3. make an endpoint for index.html to be in root /
  4. serve request for files that endpoints were made for; for others, a generic 500 was returned.

the new flow:
1. request server start
2. make an endpoint for index.html to be in root /
3. when a request is made, the fallback function is called with a bind being the endpoint
4. open file in the server directory if it exists, if not, or if reading the file fails, return 500.

since e44cac165a, godot-http-server was synced with upstream (where relevant), the binds system was deprecated, and the flow is updated to not use the fallback function:

  1. request server start
  2. make an endpoint for "/", which would match any path, and bind it to the _serve_file() function
  3. open file in the server directory if it exists. if not, or if reading the file fails, return 500.
    1. additionally, if the endpoint is /, replace the file path with index.html.

this also gave me an idea: in the future, it would be cool to specify custom error pages

~~partially~~ addresses #8. the old server flow was: 1. request server start 2. make an endpoint for every file in the server directory, with a bind being the file name 3. make an endpoint for `index.html` to be in root `/` 4. serve request for files that endpoints were made for; for others, a generic 500 was returned. ~~the new flow:~~ ~~1. request server start~~ ~~2. make an endpoint for `index.html` to be in root `/`~~ ~~3. when a request is made, the fallback function is called with a bind being the endpoint~~ ~~4. open file in the server directory if it exists, if not, or if reading the file fails, return 500.~~ since e44cac165a, [godot-http-server](https://https://github.com/velopman/godot-http-server/) was synced with upstream (where relevant), the binds system was deprecated, and the flow is updated to not use the fallback function: 1. request server start 2. make an endpoint for "/", which would match any path, and bind it to the `_serve_file()` function 3. open file in the server directory if it exists. if not, or if reading the file fails, return 500. 1. additionally, if the endpoint is `/`, replace the file path with `index.html`. this also gave me an idea: in the future, it would be cool to specify custom error pages
yagich added the
enhancement
 label 2022-07-03 20:46:44 +00:00
yagich added 1 commit 2022-07-03 20:46:45 +00:00
make the endpoints at request time 3d2fd37191
yagich added 1 commit 2022-07-04 03:44:06 +00:00
sync http-server with upstream and properly check for endpoints e44cac165a
yagich merged commit 47dc68028c into main 2022-07-04 20:04:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
xananax yagich
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yagich/tickle-godot-frontend#9
No description provided.
Delete Branch "serve-on-request"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?