yagich/tickle-godot-frontend
1
0
Fork 1
Code Issues 9 Pull Requests 1 Projects Releases Wiki Activity

WIP: add theme #10

Draft
yagich wants to merge 5 commits from theme into main
pull from: theme
merge into: yagich:main
Conversation 5 Commits 5 Files Changed 32 +506 -62
yagich commented 2022-07-04 01:13:50 +00:00
Owner
Copy Link

currently supported controls: Button, LineEdit, TextEdit (uses the same styleboxes as LineEdit), and VScrollBar (hacky), CheckBox, PopupMenu, Tree.
initially inspired by the GDQuest theme.

fonts are TBD, currently uses FreeSans and FreeMono Fira Sans. feel free to suggest alternatives.

outdated progress screenshot:
image

for newer screenshots, see comments.

currently supported controls: Button, LineEdit, TextEdit (uses the same styleboxes as LineEdit), and VScrollBar (hacky), CheckBox, PopupMenu, Tree. initially inspired by the GDQuest theme. fonts are TBD, currently uses ~~FreeSans and FreeMono~~ Fira Sans. feel free to suggest alternatives. outdated progress screenshot: ![image](/attachments/100315d7-2325-41ec-a4b2-70c4073c490b) for newer screenshots, see comments.
image.png
108 KiB
yagich added the
enhancement
 label 2022-07-04 01:13:50 +00:00
yagich added 1 commit 2022-07-04 01:13:51 +00:00 
currently supported controls: Button, LineEdit, TextEdit, and VScrollBar.
yagich added 1 commit 2022-07-18 20:02:18 +00:00
yagich commented 2022-07-18 20:08:05 +00:00
Author
Owner
Copy Link

still missing: clear color, better fonts. i think everything that is used is themed, except the popup dialogs, but i kinda like them that way?
image
image

still missing: clear color, better fonts. i think everything that is used is themed, except the popup dialogs, but i kinda like them that way? ![image](/attachments/8d777c44-c100-44ac-a892-0799d0641f40) ![image](/attachments/b6f6727b-162e-49a9-9859-d2f0b8a8ed5b)
image.png
72 KiB
image.png
60 KiB
yagich added 1 commit 2022-07-18 20:17:06 +00:00
yagich added 1 commit 2022-08-23 09:11:52 +00:00
yagich commented 2022-08-23 09:12:03 +00:00
Author
Owner
Copy Link

darker clear color, changed display font to Fira Sans, changed content font to Fira Sans Light. thoughts?image

darker clear color, changed display font to Fira Sans, changed content font to Fira Sans Light. thoughts?![image](/attachments/7ed81d67-cb7e-41dc-9600-149ab2460988)
yagich commented 2022-08-23 09:15:44 +00:00
Author
Owner
Copy Link

committed the vscode folder by mistake, damnit
edit: all good now, learnt about squashing in the process ;P

~~committed the vscode folder by mistake, damnit~~ edit: all good now, learnt about squashing in the process ;P
yagich force-pushed theme from ea3c36f534 to e80043bd6b 2022-08-23 09:20:09 +00:00 Compare
yagich added 1 commit 2022-08-23 09:20:45 +00:00
xananax commented 2022-08-24 21:38:28 +00:00
Collaborator
Copy Link

Looks pretty neat! Is there anything specific you'd like me to review?

Looks pretty neat! Is there anything specific you'd like me to review?
yagich commented 2022-08-25 06:38:41 +00:00
Author
Owner
Copy Link

not much in particular, just wanted to ask if the overall feel is nice. also, if i can avoid theming the dialogs, that'd be nice, they look pretty alright as is i feel. if everything looks ok, i think this will be ready for merge after i do some cleanup

not much in particular, just wanted to ask if the overall feel is nice. also, if i can avoid theming the dialogs, that'd be nice, they look pretty alright as is i feel. if everything looks ok, i think this will be ready for merge after i do some cleanup
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin theme:theme
git checkout theme
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: yagich/tickle-godot-frontend#10
No description provided.
Delete Branch "theme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?